Disable production limits on snapshot builds #16835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables the production limits checks on snapshot builds. This is at a minimum short-term relief for developers that do in fact bind to external network interfaces, and is possibly a long-term fix as well. The situation with using the JVM flag MaxFDLimit is far too complicated.
jasontedor
added
>enhancement
review
:Delivery/Build
This was referenced Feb 27, 2016
|
LGTM |
|
Basically this means we do not test what users run in production? |
@rmuir I plan to refactor a bit and add some tests early next week. I'll add an issue tomorrow so that this isn't lost. |
|
Thanks @jasontedor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables the production limits checks on snapshot
builds. This is at a minimum short-term relief for developers that do in
fact bind to external network interfaces, and is possibly a long-term
fix as well. The situation with using the JVM flag MaxFDLimit is far too
complicated.
Closes #16813