Remove lowercase_expanded_terms and locale from query-parser options.
#20208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2016
| @@ -82,7 +80,8 @@ | |||
| private static final ParseField ALLOW_LEADING_WILDCARD_FIELD = new ParseField("allow_leading_wildcard"); | |||
| private static final ParseField AUTO_GENERATE_PHRASE_QUERIES_FIELD = new ParseField("auto_generate_phrase_queries"); | |||
| private static final ParseField MAX_DETERMINED_STATES_FIELD = new ParseField("max_determined_states"); | |||
| private static final ParseField LOWERCASE_EXPANDED_TERMS_FIELD = new ParseField("lowercase_expanded_terms"); | |||
| private static final ParseField LOWERCASE_EXPANDED_TERMS_FIELD = new ParseField("lowercase_expanded_terms") | |||
| .withAllDeprecated("Decision is now made by the analyzer"); | |||
There was a problem hiding this comment.
Is it really a deprecation ? Shouldn't we try to detect if the parameter is present and throw a nice exception if it happens ?
|
Left minor comments about deprecation vs exception, LGTM otherwise |
|
@jimferenczi Thanks for having a look! The reasoning for using deprecation rather than throwing errors is to not force users to fix their queries at the same time as they upgrade the cluster, which is why I made clear in the upgrade notes that these parameters would be ignored. Since we should now do the right thing in all cases, I don't think this would cause bad surprises? |
Fine with me, thanks for the explanation. |
jpountz
force-pushed
the
remove_lowercase_expanded_terms
branch
from
174358e
to
fff283d
Compare
|
I revived this pull request now that Lucene 6.3 has the bugfix for normalization and DelegatingAnalyzer (https://issues.apache.org/jira/browse/LUCENE-7429). @jimczi Would you mind having another look? |
jpountz
force-pushed
the
remove_lowercase_expanded_terms
branch
from
fff283d
to
9044e9b
Compare
…ons. Lucene 6.2 introduces the new `Analyzer.normalize` API, which allows to apply only character-level normalization such as lowercasing or accent folding, which is exactly what is needed to process queries that operate on partial terms such as `prefix`, `wildcard` or `fuzzy` queries. As a consequence, the `lowercase_expanded_terms` option is not necessary anymore. Furthermore, the `locale` option was only needed in order to know how to perform the lowercasing, so this one can be removed as well. Closes elastic#9978
jpountz
force-pushed
the
remove_lowercase_expanded_terms
branch
from
9044e9b
to
b53b848
Compare
|
@elasticmachine retest this please |
jpountz
added a commit
that referenced
this pull request
Nov 2, 2016
…ons. (#20208) Lucene 6.2 introduces the new `Analyzer.normalize` API, which allows to apply only character-level normalization such as lowercasing or accent folding, which is exactly what is needed to process queries that operate on partial terms such as `prefix`, `wildcard` or `fuzzy` queries. As a consequence, the `lowercase_expanded_terms` option is not necessary anymore. Furthermore, the `locale` option was only needed in order to know how to perform the lowercasing, so this one can be removed as well. Closes #9978
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 27, 2017
Add `quote_field_suffix` to simple_query_string query Deprecate `lowercase_expanded_terms` and `locale`: elastic/elasticsearch#20208 Add "all field" execution mode to query_string and simple_query_string query: elastic/elasticsearch#20925 Fixes #2792
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 29, 2017
Add `quote_field_suffix` to simple_query_string query Deprecate `lowercase_expanded_terms` and `locale`: elastic/elasticsearch#20208 Add "all field" execution mode to query_string and simple_query_string query: elastic/elasticsearch#20925 Fixes #2792
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 29, 2017
* Add missing fields on simple query string query Add `quote_field_suffix` to simple_query_string query Deprecate `lowercase_expanded_terms` and `locale`: elastic/elasticsearch#20208 Add "all field" execution mode to query_string and simple_query_string query: elastic/elasticsearch#20925 Fixes #2792 * Convert to property expressions
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 29, 2017
* Add missing fields on simple query string query Add `quote_field_suffix` to simple_query_string query Deprecate `lowercase_expanded_terms` and `locale`: elastic/elasticsearch#20208 Add "all field" execution mode to query_string and simple_query_string query: elastic/elasticsearch#20925 Fixes #2792 * Convert to property expressions (cherry picked from commit bef4b9d)
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
* Add missing fields on simple query string query Add `quote_field_suffix` to simple_query_string query Deprecate `lowercase_expanded_terms` and `locale`: elastic/elasticsearch#20208 Add "all field" execution mode to query_string and simple_query_string query: elastic/elasticsearch#20925 Fixes elastic#2792 * Convert to property expressions (cherry picked from commit bef4b9d)
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucene 6.2 introduces the new
Analyzer.normalizeAPI, which allows to applyonly character-level normalization such as lowercasing or accent folding, which
is exactly what is needed to process queries that operate on partial terms such
as
prefix,wildcardorfuzzyqueries. As a consequence, thelowercase_expanded_termsoption is not necessary anymore. Furthermore, thelocaleoption was only needed in order to know how to perform the lowercasing,so this one can be removed as well.
Closes #9978