Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Improve size regex in documentation test #26879

Merged
merged 5 commits into from
Nov 13, 2017
Merged

Tests: Improve size regex in documentation test #26879

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
99c4c27
Tests: Improve size regex in documentation test
spinscale Oct 4, 2017
e3fe429
Merge branch 'master' into 1710-fix-regex-in-docs
spinscale Nov 8, 2017
658cd4a
fixing regex to only support bytes/kbytes
spinscale Nov 8, 2017
edd2b41
Merge branch 'master' into 1710-fix-regex-in-docs
spinscale Nov 9, 2017
3f62665
Another regex refinement, removing grouping, making the dot optional
spinscale Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference/getting-started.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ And the response:
health status index uuid pri rep docs.count docs.deleted store.size pri.store.size
yellow open customer 95SQ4TSUT7mWBT7VNHH67A 5 1 0 0 260b 260b
--------------------------------------------------
// TESTRESPONSE[s/95SQ4TSUT7mWBT7VNHH67A/.+/ s/260b/\\d+b/ _cat]
// TESTRESPONSE[s/95SQ4TSUT7mWBT7VNHH67A/.+/ s/260b/\\d+(\\.\\d+)?b/ _cat]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also cover the case where the unit changes from b to kb ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does \d+(\.\d)?[kbg]?b sound better? With that 1.1b, 100b, 12.1gb, 1.1kb should match

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think restricting it to kb and b only for this test would be better, we should detect if the value suddenly jumps to mb here for an almost empty index. So adding k? to the mix should be enough IMHO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbuescher ++ that's what I had in mind too.


The results of the second command tells us that we now have 1 index named customer and it has 5 primary shards and 1 replica (the defaults) and it contains 0 documents in it.

Expand Down