Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case sensitivity bug in application privileges #31491

Merged
merged 3 commits into from
Jun 26, 2018

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Jun 21, 2018

The was a spurious toLowerCase in the privilege check that was left
over from a previous design approach

The was a spurious toLowerCase in the privilege check that was left
over from a previous design approach
@tvernum tvernum added >bug :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC labels Jun 21, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@tvernum
Copy link
Contributor Author

tvernum commented Jun 21, 2018

FYI @kobelb

@tvernum
Copy link
Contributor Author

tvernum commented Jun 21, 2018

@albertzaharovits I offer 1 🍺 for this review ;)

Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM neat and clean as usual, Thanks!

@tvernum tvernum merged commit d509bd2 into elastic:security-app-privs Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants