[ML] fix updating opened jobs scheduled events (#31651) #32881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assertEquals(params.getDetectorUpdates(), updateBuilder.build().getDetectorUpdates()); | ||
| assertEquals(params.getModelPlotConfig(), updateBuilder.build().getModelPlotConfig()); | ||
|
|
||
| updateBuilder.setGroups(Arrays.asList("bar")); |
There was a problem hiding this comment.
nit: Why not call this earlier where the rest of the update is built? There is no reason to separate the groups from this test's perspective.
| /** | ||
| * An open job that later gets added to a calendar, should take the scheduled events into account | ||
| */ | ||
| public void testUpdatingOpenedJob() throws Exception { |
There was a problem hiding this comment.
We now have 2 tests that deal with online updates. The old one is testing online updates with regard to adding events to a calendar. This one tests online updates with regard to adding the job to a group for which there's calendars. How about we rename those tests to reflect that? testOnlineUpdate -> testAddEventsToOpenJob and testUpdatingOpenedJob -> testAddOpenedJobToGroupWithCaldendar are some suggestive names but if you have better ideas go for it.
There was a problem hiding this comment.
The two hardest problems in software development:
- Cache invalidation
- Naming things
:D
| public void testUpdatingOpenedJob() throws Exception { | ||
| TimeValue bucketSpan = TimeValue.timeValueMinutes(30); | ||
| String groupName = "opened-calendar-job-group"; | ||
| Job.Builder job = createJob("scheduled-events-open-update", bucketSpan); |
There was a problem hiding this comment.
Note that in all those integ-tests we try to name the job after the class/test itself. We found in the past that makes it easier to debug a failed test. Could you please adjust according to the final test name?
dimitris-athanasiou
approved these changes
Aug 16, 2018
|
retest this please |
dimitris-athanasiou
changed the title
|
retest this please |
|
retest this please |
benwtrent
added a commit
that referenced
this pull request
Aug 17, 2018
jasontedor
added a commit
that referenced
this pull request
Aug 18, 2018
* elastic/master: (46 commits) NETWORKING: Make RemoteClusterConn. Lazy Resolve DNS (#32764) [DOCS] Splits the users API documentation into multiple pages (#32825) [DOCS] Splits the token APIs into separate pages (#32865) [DOCS] Creates redirects for role management APIs page Bypassing failing test PainlessDomainSplitIT#testHRDSplit (#32966) TEST: Mute testRetentionPolicyChangeDuringRecovery [DOCS] Fixes more broken links to role management APIs [Docs] Tweaks and fixes to rollup docs [DOCS] Fixes links to role management APIs [ML][TEST] Fix BasicRenormalizationIT after adding multibucket feature [DOCS] Splits the roles API documentation into multiple pages (#32794) [TEST] Run pre 6.4 nodes in non-FIPS JVMs (#32901) Make Geo Context Mapping Parsing More Strict (#32821) [ML] fix updating opened jobs scheduled events (#31651) (#32881) Scripted metric aggregations: add deprecation warning and system property to control legacy params (#31597) Tests: Fix timezone conversion in DateTimeUnitTests Enable FIPS140LicenseBootstrapCheck (#32903) Fix InternalAutoDateHistogram reproducible failure (#32723) Remove assertion in testDocStats on deletedDocs counter (#32914) HLRC: Move ML request converters into their own class (#32906) ...
jasontedor
added a commit
that referenced
this pull request
Aug 18, 2018
* 6.x: (42 commits) [DOCS] Splits the users API documentation into multiple pages (#32825) [DOCS] Splits the token APIs into separate pages (#32865) [DOCS] Creates redirects for role management APIs page Bypassing failing test PainlessDomainSplitIT#testHRDSplit (#32966) TEST: Mute testRetentionPolicyChangeDuringRecovery [DOCS] Fixes more broken links to role management APIs [Docs] Tweaks and fixes to rollup docs [DOCS] Fixes links to role management APIs [ML][TEST] Fix BasicRenormalizationIT after adding multibucket feature [DOCS] Splits the roles API documentation into multiple pages (#32794) [TEST] Run pre 6.4 nodes in non-FIPS JVMs (#32901) Remove assertion in testDocStats on deletedDocs counter (#32914) [ML] fix updating opened jobs scheduled events (#31651) (#32881) Enable FIPS140LicenseBootstrapCheck (#32903) HLRC: Move ML request converters into their own class (#32906) [DOCS] Update getting-started.asciidoc (#29518) Fix allowed value for HighlighterBuilder encoder in javadocs (#32780) [DOCS] Add "remove a tag" script logic as an example (#32556) RFC: Test that example plugins build stand-alone (#32235) Security: remove put privilege API (#32879) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #31651
Now, if there is a group update, we alert that the scheduled events for the job should be updated as well.
Closes #31651