Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verson bump to 8 on master #38531

Closed
wants to merge 4 commits into from
Closed

Conversation

alpar-t
Copy link
Contributor

@alpar-t alpar-t commented Feb 6, 2019

Contains changes in #38513 as well.

@DaveCTurner
Copy link
Contributor

Just a heads-up that there's a booby-trap here:

assert Version.CURRENT.major == Version.V_6_6_0.major + 1 : "remove this service once unsafe upgrades are no longer needed";

I am working on a commit that deletes the offending code.

@DaveCTurner
Copy link
Contributor

When you're ready, you can cherry-pick 1898ee4776c541e0c2a5b4428f64aaa5dacb8164 which removes the Zen1 BWC infrastructure that this assertion asserts to be absent. You may need to fetch that from my fork: https://github.com/DaveCTurner/elasticsearch/tree/2019-02-06-remove-zen1-bwc

@jasontedor
Copy link
Member

I ported all these commits over to #38514. Thanks all for the contributions, let's continue the effort there.

@jasontedor jasontedor closed this Feb 6, 2019
@alpar-t alpar-t deleted the verson-bump-8 branch November 11, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants