Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copy_settings flag from resize operations #38553

Closed
wants to merge 1 commit into from

Conversation

jkakavas
Copy link
Member

@jkakavas jkakavas commented Feb 7, 2019

This commit removes the copy_settings flag for shrink and split
operations. The flag was introduced in
#30255 and the default
value from now on is for the settings to be copied.

This commit removes the `copy_settings` flag for shrink and split
operations. The flag was introduced in
elastic#30255 and the default
value from now onwards is for the settings to be copied.
@jkakavas jkakavas added >non-issue :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0 labels Feb 7, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be good to have another set of eyes checking this change.

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - as a follow up we should also remove the copy settings from the ResizeRequest object

@alpar-t
Copy link
Contributor

alpar-t commented Feb 7, 2019

Thanks @jkakavas for this. I'm going to incorporate it to #38514.

@alpar-t alpar-t closed this Feb 7, 2019
albertzaharovits added a commit to jasontedor/elasticsearch that referenced this pull request Feb 7, 2019
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Jul 9, 2021
previously removed in elastic#38553, deprecated in 7.x and defaulted to true.
With rest api compatibility value is ignored and warning is emitted

relates elastic#51816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >non-issue v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants