Obsolete pre 7.0 noarch package in rpm #39472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the rpm metadata indicate the pre 7.0 noarch packages are obsoleted by this package. This fixes an issue where upgrading with yum would cause an error thinking there was nothing to upgrade. closes elastic#39414
rjernst
added
>bug
:Delivery/Packaging
|
Pinging @elastic/es-core-infra |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 28, 2019
This commit makes the rpm metadata indicate the pre 7.0 noarch packages are obsoleted by this package. This fixes an issue where upgrading with yum would cause an error thinking there was nothing to upgrade. closes elastic#39414
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 28, 2019
This commit makes the rpm metadata indicate the pre 7.0 noarch packages are obsoleted by this package. This fixes an issue where upgrading with yum would cause an error thinking there was nothing to upgrade. closes elastic#39414
alpar-t
reviewed
Feb 28, 2019
| @@ -330,6 +331,8 @@ Closure commonRpmConfig(boolean oss) { | |||
| packageGroup 'Application/Internet' | |||
| requires '/bin/bash' | |||
|
|
|||
| obsoletes packageName, '7.0.0', Flags.LESS | |||
There was a problem hiding this comment.
@rjernst Could it be that we are missing or need to improve some upgrade test ?
It seems that lack of this should have caused an upgrade to fail.
Might be because there was no conflicts so both got installed ?
rjernst
added a commit
that referenced
this pull request
Feb 28, 2019
This commit makes the rpm metadata indicate the pre 7.0 noarch packages are obsoleted by this package. This fixes an issue where upgrading with yum would cause an error thinking there was nothing to upgrade. closes #39414
rjernst
added a commit
that referenced
this pull request
Feb 28, 2019
This commit makes the rpm metadata indicate the pre 7.0 noarch packages are obsoleted by this package. This fixes an issue where upgrading with yum would cause an error thinking there was nothing to upgrade. closes #39414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the rpm metadata indicate the pre 7.0 noarch packages
are obsoleted by this package. This fixes an issue where upgrading with
yum would cause an error thinking there was nothing to upgrade.
closes #39414