Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix deprecation notification #40980

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 8, 2019

Related to elastic/docs#778

This PR simplifies a deprecation notification, which was causing problems when the page was built via Asciidoctor.

@lcawl lcawl added >docs General docs changes v7.0.0 v8.0.0 v7.2.0 labels Apr 8, 2019
@lcawl lcawl requested a review from nik9000 April 8, 2019 18:16
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine by me. We can move the sentence back into the deprecated[] tag after we've converted too.

@lcawl lcawl merged commit f49429b into elastic:master Apr 8, 2019
@lcawl lcawl deleted the deprecation-fix branch April 8, 2019 18:36
lcawl added a commit that referenced this pull request Apr 8, 2019
lcawl added a commit that referenced this pull request Apr 8, 2019
@polyfractal polyfractal added v7.0.1 and removed v7.0.0 labels Apr 9, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants