Remove /var/run/elasticsearch from packages #41102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pid dir for both systemd and init.d is already managed by those respective systems (tmpfiles.d and the init script, respectively). Since the /var/run dir is often mounted as tmpfs, it does not make sense to have the elasticsearch pid dir added by the package installation. This commit removes that empty dir from deb and rpm.
rjernst
added
>non-issue
:Delivery/Packaging
|
Pinging @elastic/es-core-infra |
|
@elasticmachine run elasticsearch-ci/1 |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 19, 2019
The pid dir for both systemd and init.d is already managed by those respective systems (tmpfiles.d and the init script, respectively). Since the /var/run dir is often mounted as tmpfs, it does not make sense to have the elasticsearch pid dir added by the package installation. This commit removes that empty dir from deb and rpm.
rjernst
added a commit
that referenced
this pull request
Apr 22, 2019
The pid dir for both systemd and init.d is already managed by those respective systems (tmpfiles.d and the init script, respectively). Since the /var/run dir is often mounted as tmpfs, it does not make sense to have the elasticsearch pid dir added by the package installation. This commit removes that empty dir from deb and rpm.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
The pid dir for both systemd and init.d is already managed by those respective systems (tmpfiles.d and the init script, respectively). Since the /var/run dir is often mounted as tmpfs, it does not make sense to have the elasticsearch pid dir added by the package installation. This commit removes that empty dir from deb and rpm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pid dir for both systemd and init.d is already managed by those
respective systems (tmpfiles.d and the init script, respectively). Since
the /var/run dir is often mounted as tmpfs, it does not make sense to
have the elasticsearch pid dir added by the package installation. This
commit removes that empty dir from deb and rpm.