-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lintian overrides #41561
Update lintian overrides #41561
Conversation
The deb package has been updated several times in the past to contain overrides in order to pass lintian inspection. However, there have never been any tests to ensure we do not fallback to failure. This commit updates the overrides file given things that have changed since 2.x like adding ML and bundling the jdk. closes elastic#17185
Pinging @elastic/es-core-infra |
distribution/packages/build.gradle
Outdated
requires 'bash' | ||
|
||
// versions found on oldest supported distro, centos-6 | ||
// nocommit: why are bash and libc only required for deb? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RPM config requires /bin/bash
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libc
needs to be addressed indeed though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some more research and found rpm automatically finds lib deps based on binary paths, eg for libc being needed by /bin/bash, so that is why it is not needed in rpm as a direct dependency.
@jasontedor Do you have any other comments on this? |
@elasticmachine run elasticsearch-ci/packaging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
||
# bundled JDK | ||
embedded-library | ||
arch-dependent-file-in-usr-share usr/share/elasticsearch/jdk/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do want to consider moving these at some point to a more proper location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think we should, but I was worried about the broad impact, although I guess we could keep plugins there? I will open a follow-up for discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah a discussion is good. The modules directory presents an interesting dilemma too.
hardening-no-pie usr/share/elasticsearch/jdk/bin/* | ||
hardening-no-pie usr/share/elasticsearch/jdk/lib/* | ||
|
||
# the system java version that lintian assumes is far behind what elasticsearch uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's cute.
@elasticmachine run elasticsearch-ci/1 |
The deb package has been updated several times in the past to contain overrides in order to pass lintian inspection. However, there have never been any tests to ensure we do not fallback to failure. This commit updates the overrides file given things that have changed since 2.x like adding ML and bundling the jdk. closes elastic#17185
The deb package has been updated several times in the past to contain overrides in order to pass lintian inspection. However, there have never been any tests to ensure we do not fallback to failure. This commit updates the overrides file given things that have changed since 2.x like adding ML and bundling the jdk. closes #17185
The deb package has been updated several times in the past to contain overrides in order to pass lintian inspection. However, there have never been any tests to ensure we do not fallback to failure. This commit updates the overrides file given things that have changed since 2.x like adding ML and bundling the jdk. closes elastic#17185
The deb package has been updated several times in the past to contain
overrides in order to pass lintian inspection. However, there have never
been any tests to ensure we do not fallback to failure. This commit
updates the overrides file given things that have changed since 2.x like
adding ML and bundling the jdk.
closes #17185