Use query in cardinality check #49939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
|
run elasticsearch-ci/2 |
dimitris-athanasiou
approved these changes
Dec 9, 2019
przemekwitek
reviewed
Dec 9, 2019
| protected static DataFrameAnalyticsConfig buildAnalytics(String id, String sourceIndex, String destIndex, | ||
| @Nullable String resultsField, DataFrameAnalysis analysis, | ||
| QueryBuilder queryBuilder) throws Exception { | ||
| return new DataFrameAnalyticsConfig.Builder() |
There was a problem hiding this comment.
The other method called buildAnalytics (starting in line 165) should call this one, as the new method is more generic.
| @@ -248,6 +250,27 @@ public void testDependentVariableCardinalityTooHighError() { | |||
| assertThat(e.getMessage(), equalTo("Field [keyword-field] must have at most [2] distinct values but there were at least [3]")); | |||
| } | |||
|
|
|||
| public void testDependentVariableCardinalityTooHighErrorButWithQuery() throws Exception { | |||
| initialize("cardinality_too_high"); | |||
There was a problem hiding this comment.
Please make the names assigned to jobs unique (currently this one and the one in line 236 are the same).
|
@elasticmachine update branch |
benwtrent
deleted the
feature/ml-dataframe-use-query-for-cardinality-check
branch
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Dec 9, 2019
benwtrent
added a commit
that referenced
this pull request
Dec 9, 2019
benwtrent
added a commit
that referenced
this pull request
Dec 9, 2019
jpountz
changed the title
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
When checking the cardinality of a field, the query should be take into account. The user might know about some bad data in their index and want to filter down to the target_field values they care about.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking the cardinality of a field, the query should be take into account. The user might know about some bad data in their index and want to filter down to the target_field values they care about.