Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gradle 6.1 #50453

Merged
merged 6 commits into from
Jan 16, 2020
Merged

Conversation

mark-vieira
Copy link
Contributor

@mark-vieira mark-vieira commented Dec 20, 2019

Preliminary testing for support with Gradle 6.1. This release also includes a fix for gradle/gradle#11426 so we are removing the workaround put in place for this issue.

In addition to the fix above, Gradle 6.1 introduces and incubating API for the concept of build services, which will allow us to clean up several nasty hacks in our build logic.
https://docs.gradle.org/current/javadoc/org/gradle/api/services/BuildService.html

Signed-off-by: Mark Vieira <portugee@gmail.com>
Signed-off-by: Mark Vieira <portugee@gmail.com>
@mark-vieira mark-vieira added >non-issue :Delivery/Build Build or test infrastructure labels Dec 20, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@mark-vieira
Copy link
Contributor Author

@elasticmachine retest this please

Signed-off-by: Mark Vieira <portugee@gmail.com>
@mark-vieira
Copy link
Contributor Author

@elasticmachine update branch

@mark-vieira mark-vieira marked this pull request as ready for review January 16, 2020 00:53
@mark-vieira
Copy link
Contributor Author

@elasticmachine update branch

@mark-vieira mark-vieira changed the title Upgrade to Gradle 6.1-rc-1 Upgrade to Gradle 6.1 Jan 16, 2020
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark-vieira mark-vieira merged commit bdd7bda into elastic:master Jan 16, 2020
@mark-vieira mark-vieira deleted the gradle-6.1-upgrade branch January 16, 2020 19:10
mark-vieira added a commit that referenced this pull request Jan 16, 2020
(cherry picked from commit bdd7bda)
mark-vieira added a commit that referenced this pull request Jan 16, 2020
(cherry picked from commit bdd7bda)
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@polyfractal polyfractal added v7.6.0 and removed v7.6.1 labels Feb 7, 2020
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v7.6.0 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants