Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MapperService#fullName to fieldType. #52025

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Rename MapperService#fullName to fieldType. #52025

merged 1 commit into from
Feb 7, 2020

Conversation

jtibshirani
Copy link
Contributor

The new name more accurately describes what the method returns.

@jtibshirani
Rename MapperService#fullName to fieldType.
a0fd7c4 
The new name more accurately describes what the method returns.
@jtibshirani jtibshirani added :Search Foundations/Mapping Index mappings, including merging and defining field types >refactoring v8.0.0 v7.7.0 v7.6.1 labels Feb 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

cbuescher
cbuescher approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, especially since fieldTypes() already returns the iterable.

@jtibshirani jtibshirani merged commit e0b3ea0 into elastic:master Feb 7, 2020
@jtibshirani jtibshirani deleted the mapper-service branch February 7, 2020 18:16
@polyfractal polyfractal added v7.6.0 and removed v7.6.1 labels Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher approved these changes

Assignees
No one assigned
Labels
>refactoring :Search Foundations/Mapping Index mappings, including merging and defining field types v7.6.0 v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jtibshirani @elasticmachine @cbuescher @jakelandis @polyfractal