-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve SERVICE_UNAVAILABLE in IdP IntegTest #54622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SamlIdentityProviderTests IntegTests would sometimes encounter a service unavailable exception when registering a new service provider. This change ensure that there is a data node, and that the cluster state is recovered before registering providers
tvernum
added
>test
Issues or PRs that are addressing/adding tests
:Security/Security
Security issues without another label
v8.0.0
v7.8.0
v7.7.1
labels
Apr 2, 2020
Pinging @elastic/es-security (:Security/Security) |
jkakavas
approved these changes
Apr 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Apr 3, 2020
The SamlIdentityProviderTests IntegTests would sometimes encounter a service unavailable exception when registering a new service provider. This change ensure that there is a data node, and that the cluster state is recovered before registering providers Backport of: elastic#54622
tvernum
added a commit
that referenced
this pull request
Apr 6, 2020
The SamlIdentityProviderTests IntegTests would sometimes encounter a service unavailable exception when registering a new service provider. This change ensure that there is a data node, and that the cluster state is recovered before registering providers Backport of: #54622
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Apr 6, 2020
The SamlIdentityProviderTests IntegTests would sometimes encounter a service unavailable exception when registering a new service provider. This change ensure that there is a data node, and that the cluster state is recovered before registering providers Backport of: elastic#54622 Backport of: elastic#54700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Security/Security
Security issues without another label
>test
Issues or PRs that are addressing/adding tests
v7.7.1
v7.8.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SamlIdentityProviderTests IntegTests would sometimes encounter a
service unavailable exception when registering a new service provider.
This change ensure that there is a data node, and that the cluster
state is recovered before registering providers
Resolves: #54555