indices.recovery.max_bytes_per_sec may be per-node #54633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `indices.recovery.max_bytes_per_sec` recovery bandwidth limit can differ between nodes if it is not set dynamically, but today this is not obvious. This commit adds a paragraph to its documentation clarifying how to set different bandwidth limits on each node.
DaveCTurner
added
>docs
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-distributed (:Distributed/Recovery) |
jrodewig
reviewed
Apr 2, 2020
Comment on lines
44
to
46
| `indices.recovery.max_concurrent_file_chunks` | ||
| (<<cluster-update-settings,Dynamic>>, Expert):: Number of file chunk requests | ||
| sent in parallel for each recovery. Defaults to `2`. |
There was a problem hiding this comment.
This doesn't render properly because :: falls on a different line.
I think we can move the parenthetical info inside the definition like this:
Suggested change
| `indices.recovery.max_concurrent_file_chunks` | |
| (<<cluster-update-settings,Dynamic>>, Expert):: Number of file chunk requests | |
| sent in parallel for each recovery. Defaults to `2`. | |
| `indices.recovery.max_concurrent_file_chunks`:: | |
| (<<cluster-update-settings,Dynamic>>, Expert) | |
| Number of file chunk requests sent in parallel for each recovery. Defaults to | |
| `2`. |
jrodewig
reviewed
Apr 2, 2020
| @@ -17,24 +16,34 @@ You can view a list of in-progress and completed recoveries using the | |||
| ==== Peer recovery settings | |||
|
|
|||
| `indices.recovery.max_bytes_per_sec` (<<cluster-update-settings,Dynamic>>):: | |||
There was a problem hiding this comment.
Github won't let me suggest, but we may want to move the parenthetical inside the definition as with indices.recovery.max_concurrent_file_chunks.
jrodewig
reviewed
Apr 2, 2020
jrodewig
reviewed
Apr 2, 2020
Comment on lines
35
to
37
| if you are using <<overview-index-lifecycle-management,Index Lifecycle | ||
| Management>> then you may restrict the recovery bandwidth on your warm nodes | ||
| more than on your hot nodes. |
There was a problem hiding this comment.
Slight reword
Suggested change
| if you are using <<overview-index-lifecycle-management,Index Lifecycle | |
| Management>> then you may restrict the recovery bandwidth on your warm nodes | |
| more than on your hot nodes. | |
| if you are use <<overview-index-lifecycle-management,Index Lifecycle | |
| Management>>, you may give hot nodes a higher recovery bandwidth limit than | |
| warm nodes. |
jrodewig
suggested changes
Apr 2, 2020
There was a problem hiding this comment.
Looks good overall, but some of the formatting is broken here:
https://github.com/elastic/elasticsearch/pull/54633/files#r402317243
I also suggested moving the parenthetical information for the setting definitions into
the definition itself. I think this makes the defs a bit more readable and helps us wrap
lines.
I left some other wording suggestions, but they're optional. Thanks @DaveCTurner.
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
|
Thanks for picking up the broken formatting -- looks better now IMO. Ready for another look. |
jrodewig
approved these changes
Apr 2, 2020
DaveCTurner
added a commit
that referenced
this pull request
Apr 2, 2020
The `indices.recovery.max_bytes_per_sec` recovery bandwidth limit can differ between nodes if it is not set dynamically, but today this is not obvious. This commit adds a paragraph to its documentation clarifying how to set different bandwidth limits on each node. Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
DaveCTurner
added a commit
that referenced
this pull request
Apr 2, 2020
The `indices.recovery.max_bytes_per_sec` recovery bandwidth limit can differ between nodes if it is not set dynamically, but today this is not obvious. This commit adds a paragraph to its documentation clarifying how to set different bandwidth limits on each node. Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
DaveCTurner
added a commit
that referenced
this pull request
Apr 2, 2020
The `indices.recovery.max_bytes_per_sec` recovery bandwidth limit can differ between nodes if it is not set dynamically, but today this is not obvious. This commit adds a paragraph to its documentation clarifying how to set different bandwidth limits on each node. Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
indices.recovery.max_bytes_per_secrecovery bandwidth limit can differbetween nodes if it is not set dynamically, but today this is not obvious. This
commit adds a paragraph to its documentation clarifying how to set different
bandwidth limits on each node.