[ML] Take more care that normalize processes use unique named pipes #54636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When one of ML's normalize processes fails to connect to the JVM quickly enough and another normalize process for the same job starts shortly afterwards it is possible that their named pipes can get mixed up. This change avoids the risk of that by adding an incrementing counter value into the named pipe names used for normalize processes. Fixes elastic#43830
|
Pinging @elastic/ml-core (:ml) |
benwtrent
approved these changes
Apr 2, 2020
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Apr 2, 2020
When one of ML's normalize processes fails to connect to the JVM quickly enough and another normalize process for the same job starts shortly afterwards it is possible that their named pipes can get mixed up. This change avoids the risk of that by adding an incrementing counter value into the named pipe names used for normalize processes. Backport of elastic#54636
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Apr 2, 2020
When one of ML's normalize processes fails to connect to the JVM quickly enough and another normalize process for the same job starts shortly afterwards it is possible that their named pipes can get mixed up. This change avoids the risk of that by adding an incrementing counter value into the named pipe names used for normalize processes. Backport of elastic#54636
droberts195
added a commit
that referenced
this pull request
Apr 2, 2020
…54641) When one of ML's normalize processes fails to connect to the JVM quickly enough and another normalize process for the same job starts shortly afterwards it is possible that their named pipes can get mixed up. This change avoids the risk of that by adding an incrementing counter value into the named pipe names used for normalize processes. Backport of #54636
droberts195
added a commit
that referenced
this pull request
Apr 2, 2020
…54642) When one of ML's normalize processes fails to connect to the JVM quickly enough and another normalize process for the same job starts shortly afterwards it is possible that their named pipes can get mixed up. This change avoids the risk of that by adding an incrementing counter value into the named pipe names used for normalize processes. Backport of #54636
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Oct 19, 2020
The changes of elastic#54636 and elastic#60395 were incorrect in their assertion that "the job ID passed to the process pipes is only used to make the file names unique". In fact it is also passed to the C++ log handler and gets logged with every message logged by the C++ processes. This PR splits the job ID and unique IDs (added in elastic#54636 and elastic#60395) so that the correct job ID is passed to the log handler. Nothing really bad happened as a result of this problem - it was just cosmetic.
droberts195
added a commit
that referenced
this pull request
Oct 19, 2020
The changes of #54636 and #60395 were incorrect in their assertion that "the job ID passed to the process pipes is only used to make the file names unique". In fact it is also passed to the C++ log handler and gets logged with every message logged by the C++ processes. This PR splits the job ID and unique IDs (added in #54636 and #60395) so that the correct job ID is passed to the log handler. Nothing really bad happened as a result of this problem - it was just cosmetic.
droberts195
added a commit
that referenced
this pull request
Oct 19, 2020
The changes of #54636 and #60395 were incorrect in their assertion that "the job ID passed to the process pipes is only used to make the file names unique". In fact it is also passed to the C++ log handler and gets logged with every message logged by the C++ processes. This PR splits the job ID and unique IDs (added in #54636 and #60395) so that the correct job ID is passed to the log handler. Nothing really bad happened as a result of this problem - it was just cosmetic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one of ML's normalize processes fails to connect to the JVM
quickly enough and another normalize process for the same job
starts shortly afterwards it is possible that their named pipes
can get mixed up.
This change avoids this risk by adding an incrementing counter
value into the named pipe names used for normalize processes.
Fixes #43830