Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Makes PUT inference API docs collapsible #54653

Merged
merged 5 commits into from
Apr 3, 2020

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Apr 2, 2020

This PR collects the properties of the PUT inference trained model API into collapsible sections.

Preview: http://elasticsearch_54653.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/put-inference.html

@szabosteve szabosteve changed the title [DOCS] Makes PUT inference API docs collapsible. [DOCS] Makes PUT inference API docs collapsible Apr 2, 2020
@szabosteve szabosteve marked this pull request as ready for review April 2, 2020 15:49
@szabosteve szabosteve added :ml Machine learning >docs General docs changes v7.8.0 v8.0.0 labels Apr 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

`tags`::
(Optional, string)
An array of tags to organize the model.


[[ml-put-inference-example]]
Copy link
Contributor

@lcawl lcawl Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's hard to figure out how all these partial examples fit together. Could we provide one full example and then just link to https://github.com/elastic/ml-json-schemas/tree/master/examples for other combinations? If yes, this can be a separate PR.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@szabosteve szabosteve merged commit a066239 into elastic:master Apr 3, 2020
@szabosteve szabosteve deleted the inference.docs.finetuning branch April 3, 2020 07:45
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Apr 3, 2020
Co-authored-by: lcawl <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml Machine learning v7.8.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants