Remove deprecated endpoints of hot threads API

[muachilin]

This PR proceeds to remove deprecated endpoints in hot threads action.

[issue: #52640]

[nik9000]

Looks good to me!

[elasticmachine]

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

[nik9000]

@elasticmachine, test this please.

@jasontedor, do you think this is worth a line in the breaking changes list? We never documented these in the first place but it'd be a kind thing to do I think.

[jasontedor]

Yes, we should add a note to the breaking changes docs. While these endpoints were not documented in the reference docs, they are in the REST spec. Also, we try to document when we break other things we don’t document, for example, the recent removal of the undocumented node.local_storage setting.

[nik9000]

Yes, we should add a note to the breaking changes docs. While these endpoints were not documented in the reference docs, they are in the REST spec. Also, we try to document when we break other things we don’t document, for example, the recent removal of the undocumented node.local_storage setting.

+1

@muachilin, would you like to add an update to docs/reference/release-notes/8.0.0-alpha1.asciidoc for the breaking change? I'd be happy to do it if you don't find it obvious what to add.

Also, it looks like there is a checkstyle error. Could you fix it?

RestNodesHotThreadsAction.java:37:8: Unused import - java.util.Locale. [UnusedImports]

Somthing like:

./gradlew -p server precommit && ./gradlew -p server check

would probably be worth doing on this locally.

[muachilin]

@elasticmachine update branch

[nik9000]

@elasticmachine, test this please.

[nik9000]

I think this is good! I'm going to merge.

[nik9000]

Thanks @muachilin !

[muachilin]

Thank you!