Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add geo_shape support for the geo_centroid aggregation #55602

Merged
merged 9 commits into from
Apr 27, 2020
Merged

Add geo_shape support for the geo_centroid aggregation #55602

merged 9 commits into from
Apr 27, 2020

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Apr 22, 2020

this commit leverages the new geo_shape doc values
to register a new geo_centroid aggregator that works
on geo_shape field.

@talevy
Add geo_shape support for the geo_centroid aggregation
f76e647 
this commit leverages the new geo_shape doc values
to register a new geo_centroid aggregator that works
on geo_shape field.
@talevy talevy added :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.0.0 v7.8.0 labels Apr 22, 2020
@talevy talevy requested review from nknize and iverase April 22, 2020 15:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@talevy
Copy link
Contributor Author

talevy commented Apr 22, 2020

test this please

@talevy
Copy link
Contributor Author

talevy commented Apr 22, 2020

Sorry, need to finalize the licensing section before review

@talevy talevy requested review from iverase and nknize April 23, 2020 02:21
iverase
iverase approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talevy talevy merged commit 3b74015 into elastic:master Apr 27, 2020
@talevy
Copy link
Contributor Author

talevy commented Apr 27, 2020

thanks Ignacio!

@talevy talevy deleted the geo_centroid3 branch April 27, 2020 16:03
@talevy talevy mentioned this pull request Apr 27, 2020
Merged
talevy added a commit that referenced this pull request Apr 27, 2020
@talevy
Add geo_shape support for the geo_centroid aggregation (#55602) (#55819)
6ba5148 
this commit leverages the new geo_shape doc values
to register a new geo_centroid aggregator that works
on geo_shape field.
@talevy talevy mentioned this pull request Apr 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iverase iverase iverase approved these changes

@nknize nknize Awaiting requested review from nknize

Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >feature release highlight v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@talevy @elasticmachine @iverase @jakelandis @giladgal