Save memory in on aggs in async search #55683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces a reference to the result of partially reducing aggregations that async search keeps with a reference to the serialized form of the result of the partial reduction which we need to keep anyway.
nik9000
added
>enhancement
blocker
:Analytics/Aggregations
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
|
And it doesn't have any of the sneaky hidden costs. |
jimczi
requested changes
Apr 24, 2020
x-pack/plugin/async-search/src/main/java/org/elasticsearch/xpack/search/AsyncSearchTask.java
Outdated
Show resolved
Hide resolved
.../plugin/async-search/src/main/java/org/elasticsearch/xpack/search/MutableSearchResponse.java
Show resolved
Hide resolved
.../plugin/async-search/src/main/java/org/elasticsearch/xpack/search/MutableSearchResponse.java
Show resolved
Hide resolved
|
run elasticsearch-ci/2 |
|
run elasticsearch-ci/bwc |
|
run elasticsearch-ci/2 |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 28, 2020
This replaces a reference to the result of partially reducing aggregations that async search keeps with a reference to the serialized form of the result of the partial reduction which we need to keep anyway.
nik9000
added a commit
that referenced
this pull request
Apr 28, 2020
|
Backport done! This was a blocker because we really didn't want to release 7.8 with the aggs referenced both in serialized and unserialized form. It just seemed like a big waste! |
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Apr 29, 2020
This commit fixes the initialization of total hits in the async search response. Relates elastic#55683 Closes elastic#55920
jimczi
added a commit
that referenced
this pull request
Apr 29, 2020
jimczi
added a commit
that referenced
this pull request
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces a reference to the result of partially reducing
aggregations that async search keeps with a reference to the serialized
form of the result of the partial reduction which we need to keep
anyway.