Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Search: correct shards counting #55758

Merged

Commits on Apr 24, 2020

  1. Async Search: correct shards counting

    Async search allows users to retrieve partial results for a running search. For partial results, the number of successful shards does not include the skipped shards, while the response returned to users should.
    
    When a fatal failure happened after some partial results were processed, for instance because all of the shards failed to fetch their hits, the number of successful shards should be reset to align it with what ordinary search would return.
    
    Also, we recently had a bug where async search would miss tracking shard failures, which would have been caught if we had assertions in place that verified that whenever we get the last response, the number of failures included in it is the same as the failures that were tracked through the listener notifications.
    javanna committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    03115aa View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Configuration menu
    Copy the full SHA
    b3db15c View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Configuration menu
    Copy the full SHA
    f377669 View commit details
    Browse the repository at this point in the history
  2. iter

    javanna committed May 6, 2020
    Configuration menu
    Copy the full SHA
    372e0ed View commit details
    Browse the repository at this point in the history