Fix validate query listener invocation bug #56157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the index we are validating a query does not exist, we try to send back a response letting the client know that the index does not exist. Yet, we accidentally fallthrough into the case that the validation failed for some other reason. This means that we end up notifying the channel twice. Sometimes the notification occurs after the failure has been written out and the channel closed (so the second invocation leads to a silent failed to write to a closed channel issue), and sometimes the response does end up in the channel, creating garbled responses to the client. This commit fixes that issue by avoiding the fallthrough.
jasontedor
added
>bug
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
mayya-sharipova
approved these changes
May 5, 2020
jasontedor
added a commit
that referenced
this pull request
May 5, 2020
When the index we are validating a query does not exist, we try to send back a response letting the client know that the index does not exist. Yet, we accidentally fallthrough into the case that the validation failed for some other reason. This means that we end up notifying the channel twice. Sometimes the notification occurs after the failure has been written out and the channel closed (so the second invocation leads to a silent failed to write to a closed channel issue), and sometimes the response does end up in the channel, creating garbled responses to the client. This commit fixes that issue by avoiding the fallthrough.
jasontedor
added a commit
that referenced
this pull request
May 5, 2020
When the index we are validating a query does not exist, we try to send back a response letting the client know that the index does not exist. Yet, we accidentally fallthrough into the case that the validation failed for some other reason. This means that we end up notifying the channel twice. Sometimes the notification occurs after the failure has been written out and the channel closed (so the second invocation leads to a silent failed to write to a closed channel issue), and sometimes the response does end up in the channel, creating garbled responses to the client. This commit fixes that issue by avoiding the fallthrough.
jasontedor
added a commit
that referenced
this pull request
May 5, 2020
When the index we are validating a query does not exist, we try to send back a response letting the client know that the index does not exist. Yet, we accidentally fallthrough into the case that the validation failed for some other reason. This means that we end up notifying the channel twice. Sometimes the notification occurs after the failure has been written out and the channel closed (so the second invocation leads to a silent failed to write to a closed channel issue), and sometimes the response does end up in the channel, creating garbled responses to the client. This commit fixes that issue by avoiding the fallthrough.
|
Thanks @mayya-sharipova! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the index we are validating a query does not exist, we try to send back a response letting the client know that the index does not exist. Yet, we accidentally fallthrough into the case that the validation failed for some other reason. This means that we end up notifying the channel twice. Sometimes the notification occurs after the failure has been written out and the channel closed (so the second invocation leads to a silent failed to write to a closed channel issue), and sometimes the response does end up in the channel, creating garbled responses to the client. This commit fixes that issue by avoiding the fallthrough.