Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Create API key API requires name request body param #56166

Merged
merged 1 commit into from
May 6, 2020

Conversation

navneet83
Copy link
Member

…ting API key

Fixes #56164. A minor update in the documentation, API key name is required when creating API key. If the API key name is not provided then the request will fail.

…ting API key

Fixes #56164. A minor update in the documentation, API key name is required when creating API key. If the API key name is not provided then the request will fail.
@navneet83 navneet83 added >docs General docs changes Team:Docs Meta label for docs team labels May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@jrodewig jrodewig changed the title Minor change in the documentation. API key name is required when crea… [DOCS] Create API key API requires name request body param May 5, 2020
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating this @navneet83.

@jrodewig jrodewig added :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v7.6.3 v7.7.1 v7.8.0 v8.0.0 labels May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Authentication)

@elasticmachine elasticmachine added the Team:Security Meta label for security team label May 5, 2020
@navneet83
Copy link
Member Author

Thank you @jrodewig! Should I commit this fix in both master and elastic:7.x branch?

@navneet83 navneet83 merged commit cbf0e78 into master May 6, 2020
@navneet83 navneet83 deleted the docs_update_api_key branch May 6, 2020 05:11
@jrodewig jrodewig added the v7.9.0 label May 6, 2020
jrodewig pushed a commit that referenced this pull request May 6, 2020
…ting API key (#56166)

Fixes #56164. A minor update in the documentation, API key name is required when creating API key. If the API key name is not provided then the request will fail.
jrodewig pushed a commit that referenced this pull request May 6, 2020
…ting API key (#56166)

Fixes #56164. A minor update in the documentation, API key name is required when creating API key. If the API key name is not provided then the request will fail.
jrodewig pushed a commit that referenced this pull request May 6, 2020
…ting API key (#56166)

Fixes #56164. A minor update in the documentation, API key name is required when creating API key. If the API key name is not provided then the request will fail.
@jrodewig
Copy link
Contributor

jrodewig commented May 6, 2020

Thanks @navneet83. I backported this to 7.8->7.6 as well.

Backport commits

master cbf0e78
7.x a649f85
7.8 f04e304
7.7 18b11c7
7.6 edb12a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Docs Meta label for docs team Team:Security Meta label for security team v7.6.3 v7.7.1 v7.8.0 v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] when creating API key, name is not optional
4 participants