SQL: fix test on incompatible client versions #56234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The incomatible client version test is changed to: - iterate on all versions prior to the allowed one_s; - format the exception message just as the server does it. The defect stemed from the fact that the clients will not send a version's qualifier, but just major.minor.revision, so the raised error/exception_message won't contain it, while the test expected it.
bpintea
added
>bug
>non-issue
>test
|
Pinging @elastic/es-ql (:Query Languages/SQL) |
costin
approved these changes
May 5, 2020
|
@elasticmachine run elasticsearch-ci/2 |
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
May 5, 2020
The incomatible client version test is changed to: - iterate on all versions prior to the allowed one_s; - format the exception message just as the server does it. The defect stemed from the fact that the clients will not send a version's qualifier, but just major.minor.revision, so the raised error/exception_message won't contain it, while the test expected it. (cherry picked from commit 4a81c8f)
bpintea
added a commit
that referenced
this pull request
May 5, 2020
The incomatible client version test is changed to: - iterate on all versions prior to the allowed one_s; - format the exception message just as the server does it. The defect stemed from the fact that the clients will not send a version's qualifier, but just major.minor.revision, so the raised error/exception_message won't contain it, while the test expected it. (cherry picked from commit 4a81c8f)
bpintea
added a commit
that referenced
this pull request
May 27, 2020
The incomatible client version test is changed to: - iterate on all versions prior to the allowed one_s; - format the exception message just as the server does it. The defect stemed from the fact that the clients will not send a version's qualifier, but just major.minor.revision, so the raised error/exception_message won't contain it, while the test expected it. (cherry picked from commit 4a81c8f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incompatible client version test is changed to:
The defect stemmed from the fact that the clients will not send a
version's qualifier, but just major.minor.revision, so the raised
error/exception_message won't contain it, while the test expected it.