Fix SnapshotStatusApisIT #56859
Merged
Fix SnapshotStatusApisIT #56859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the unlikely event that the data nodes started snapshotting the shards already (and hence got blocked on the data blobs) before the master has applied the cluster state to its own `SnapshotsService` on the CS applier thread, we can get a `SnapshotMissingException` here which breaks the busy assert loop so we have to deal with it explicitly. Closes elastic#56858
original-brownbear
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
|
Thanks Nik! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 16, 2020
In the unlikely event that the data nodes started snapshotting the shards already (and hence got blocked on the data blobs) before the master has applied the cluster state to its own `SnapshotsService` on the CS applier thread, we can get a `SnapshotMissingException` here which breaks the busy assert loop so we have to deal with it explicitly. Closes elastic#56858
original-brownbear
added a commit
that referenced
this pull request
May 16, 2020
In the unlikely event that the data nodes started snapshotting the shards already (and hence got blocked on the data blobs) before the master has applied the cluster state to its own `SnapshotsService` on the CS applier thread, we can get a `SnapshotMissingException` here which breaks the busy assert loop so we have to deal with it explicitly. Closes #56858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the unlikely event that the data nodes started snapshotting the
shards already (and hence got blocked on the data blobs) before the
master has applied the cluster state to its own
SnapshotsServiceonthe CS applier thread, we can get a
SnapshotMissingExceptionhere whichbreaks the busy assert loop so we have to deal with it explicitly.
(this became a possibility now that the snapshot INIT state is gone via #55918)
Closes #56858