Cleanup xpack build.gradle #60554
Cleanup xpack build.gradle #60554
Conversation
jakelandis
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
There was a problem hiding this comment.
Removes evaluationDependsOn(xpackModule('core')) from build.gradle files under x-pack
Yay!
I'm not completely convinced that our build files should be licensed under the Elastic license just because they pertain to x-pack projects. @jasontedor do you have an opinion on this?
x-pack/plugin/async/build.gradle
Outdated
| @@ -25,5 +22,7 @@ dependencyLicenses { | |||
| ignoreSha 'x-pack-core' | |||
| } | |||
|
|
|||
| //no tests | |||
| test.enabled = false | |||
There was a problem hiding this comment.
Can we similarly use the lazy configuration apis here, ie. tasks.named("test").configure { }.
Had a side discussion and decided to remove all the headers and let the implicit Apache license take effect. The goal here was not to apply a license, just to make all of the files the same, which this PR now does. |
This commit does three things:
* Removes all Copyright/license headers for the build.gradle files under x-pack. (implicit Apache license)
* Removes evaluationDependsOn(xpackModule('core')) from build.gradle files under x-pack
* Removes a place holder test in favor of disabling the test task (in the async plugin)
# Conflicts:
# x-pack/plugin/security/build.gradle
# x-pack/plugin/watcher/build.gradle
This commit does three things:
* Removes all Copyright/license headers for the build.gradle files under x-pack. (implicit Apache license)
* Removes evaluationDependsOn(xpackModule('core')) from build.gradle files under x-pack
* Removes a place holder test in favor of disabling the test task (in the async plugin)
mark-vieira
added
Team:Delivery
This commit does three things:
evaluationDependsOn(xpackModule('core'))from build.gradle files under x-pack========
This PR looks like alot of changes...but it is really only removing headers, removing an uncessary evaluationDependsOn, and removes a dummy test.