-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EQL: [Test] Add a test for identifier
as eventType
#63227
Conversation
Add a unit test to verify that an identifier surrounded with backquotes is not a valid syntax for eventType value, as eventType is schemantically a string literal and not a field identifier. Follows: elastic#63169
Pinging @elastic/es-ql (:Query Languages/EQL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This schematic conclusion seems more like an implementation detail of EQL in Elasticsearch, and less a property of EQL the language proper. For some historical context, we had a few discussions in the early implementation last year for EQL in ES about how this concept translated into ES most naturally, and the conclusion we arrived at for FWIW, in some other implementations it makes more sense to treat this as an identifier, since the event type lives outside of the event data, and is not simply used a shorthand for So I agree that it's not a field identifer, but moreso an event type identifier. There are also other kinds of identifiers or rather "names" in the language than just field identifiers/names: function names, pipe names and relationship names/types. |
Add a unit test to verify that an identifier surrounded with backquotes
is not a valid syntax for eventType value, as eventType is
schematically a string literal and not a field identifier.
Follows: #63169