EQL: [Tests] enable server side debugging #64308
Conversation
Register a new task `runEqlCorrectnessNode` which enables developers to start an ES node in debug mode, properly restore the correctness data and then run queries against it.
matriv
added
>test
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
elasticmachine
added
the
Team:QL (Deprecated)
| @@ -105,18 +77,6 @@ public static void logTotalExecutionTime() { | |||
| LOGGER.info("Total time: {} ms", totalTime); | |||
| } | |||
|
|
|||
| @AfterClass | |||
There was a problem hiding this comment.
Because when you have a running ES node and you try to execute a single query against it with gradle, the termination of the suite will delete the data, and you'd have to rerun the EqlDataLoader.
| // Need to setup the log configuration properly to avoid messages when creating a new RestClient | ||
| PluginManager.addPackage(LogConfigurator.class.getPackage().getName()); | ||
|
|
||
| Properties configuration = loadConfiguration(); |
There was a problem hiding this comment.
You could load the Properties inside the try() { .... } block.
| } | ||
|
|
||
| static Properties loadConfiguration() throws IOException { | ||
| try (InputStream is = EsEQLCorrectnessIT.class.getClassLoader().getResourceAsStream(PROPERTIES_FILENAME)) { |
There was a problem hiding this comment.
To be 100% correct, I think it should be EqlDataLoader's class loader to load the properties file.
There was a problem hiding this comment.
yep, copy paste leftover.
| Once the ES node is up and running, the data can be restored from the snapshot by running the `main` of the | ||
| `EqlDataLoader` class. | ||
|
|
||
| Once the data is loaded, a specific query can ber run against the running ES node with: |
| If one wants to run an ES node manually (most probably to be able to debug the server), needs to run the following: | ||
|
|
||
| ```shell script | ||
| ./gradlew -p x-pack/plugin/eql/qa/correctness runEqlCorrectnessNode --debug-jvm |
There was a problem hiding this comment.
If below you provided an example gradlew command without using -p, I think it's better to be consistent and either use here the same format as the other command or use -p in both places. Not sure of the differences though, but I've been advised lately to stop using the -p format in favor of something like gradlew :x-pack:plugin:eql:qa:correctness:runEqlCorrectness --debug-jvm
| RequestOptions.DEFAULT | ||
| ); | ||
| } | ||
| EqlDataLoader.restoreSnapshot(client(), highLevelClient(), CFG); |
There was a problem hiding this comment.
The highLevelClient has a reference to the rest client already (through getLowLevelClient()), I don't think you need to pass client() here.
| @@ -5,10 +5,11 @@ | |||
| # | |||
|
|
|||
| index_name=mitre | |||
| index_doc_count=3950632 | |||
| @@ -36,3 +44,8 @@ tasks.named('javaRestTest').configure { | |||
| showStandardStreams = true | |||
| } | |||
| } | |||
|
|
|||
| tasks.register("runEqlCorrectnessNode", RunTask) { | |||
Register a new task `runEqlCorrectnessNode` which enables developers to start an ES node in debug mode, properly restore the correctness data and then run queries against it. Assert the index is restored correctly and use new snapshot. (cherry picked from commit fc8c6dd)
Register a new task `runEqlCorrectnessNode` which enables developers to start an ES node in debug mode, properly restore the correctness data and then run queries against it. Assert the index is restored correctly and use new snapshot. (cherry picked from commit fc8c6dd)
Register a new task `runEqlCorrectnessNode` which enables developers to start an ES node in debug mode, properly restore the correctness data and then run queries against it. Assert the index is restored correctly and use new snapshot. (cherry picked from commit fc8c6dd)
Register a new task `runEqlCorrectnessNode` which enables developers to start an ES node in debug mode, properly restore the correctness data and then run queries against it. Assert the index is restored correctly and use new snapshot. (cherry picked from commit fc8c6dd)
Register a new task
runEqlCorrectnessNodewhich enables developers tostart an ES node in debug mode, properly restore the correctness data
and then run queries against it.