Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IndexMetadataUpgradeService to IndexMetadataVerifier #67547

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Refactor IndexMetadataUpgradeService to IndexMetadataVerifier #67547

merged 3 commits into from
Feb 2, 2021

Conversation

jtibshirani
Copy link
Contributor

@jtibshirani jtibshirani commented Jan 15, 2021 •
edited
Loading

This PR removes support for index metadata upgrades:

  • Stop using the index.version.upgrade setting and deprecate it.
  • Remove MetadataIndexUpgradeService and other references to upgrades.

In addition to supporting upgrades, MetadataIndexUpgradeService verified
certain aspects of the metadata, like index version compatibility. This logic
is important to keep, so MetadataIndexUpgradeService was reworked to
IndexMetadataVerifier instead of being removed completely.

Closes #66143.

@jtibshirani jtibshirani changed the title Remove IndexMetadataUpgradeService. Refactor IndexMetadataUpgradeService to IndexMetadataVerifier Jan 26, 2021
@jtibshirani jtibshirani added :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >refactoring labels Jan 26, 2021
@jtibshirani jtibshirani marked this pull request as ready for review January 26, 2021 22:27
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Jan 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@jtibshirani jtibshirani mentioned this pull request Jan 26, 2021
Closed
@ywelsch ywelsch self-requested a review February 2, 2021 07:23
ywelsch
ywelsch approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtibshirani
Copy link
Contributor Author

Thanks for the review!

@jtibshirani jtibshirani merged commit 6be3a50 into elastic:master Feb 2, 2021
@jtibshirani jtibshirani deleted the upgrade-index-metadata branch February 2, 2021 17:14
@jtibshirani jtibshirani mentioned this pull request Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

@DaveCTurner DaveCTurner Awaiting requested review from DaveCTurner

Assignees
No one assigned
Labels
:Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >refactoring Team:Distributed Meta label for distributed team v7.12.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider removing MetadataIndexUpgradeService
4 participants
@jtibshirani @elasticmachine @ywelsch @jakelandis