Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one in testDoesNotSubmitRerouteTaskTooFrequently #68316

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Fix off-by-one in testDoesNotSubmitRerouteTaskTooFrequently #68316

merged 1 commit into from
Feb 2, 2021

Conversation

DaveCTurner
Copy link
Contributor

We reroute when the elapsed time is >= 60000ms, but the test assumes
that no reroute happens exactly at 60000ms. This commit fixes this
off-by-one-ms error.

@DaveCTurner
Fix off-by-one in testDoesNotSubmitRerouteTaskTooFrequently
71813df 
We reroute when the elapsed time is >= 60000ms, but the test assumes
that no reroute happens exactly at 60000ms. This commit fixes this
off-by-one-ms error.
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v8.0.0 v7.12.0 v7.11.1 labels Feb 1, 2021
@DaveCTurner DaveCTurner requested a review from tlrx February 1, 2021 17:28
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Feb 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner DaveCTurner mentioned this pull request Feb 1, 2021
Merged
original-brownbear
original-brownbear approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tlrx
tlrx approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 2

@DaveCTurner DaveCTurner merged commit 8296593 into elastic:master Feb 2, 2021
@DaveCTurner
Copy link
Contributor Author

Thanks both

@DaveCTurner DaveCTurner deleted the 2021-02-01-fix-off-by-one-testDoesNotSubmitRerouteTaskTooFrequently branch February 2, 2021 07:42
DaveCTurner added a commit that referenced this pull request Feb 2, 2021
@DaveCTurner
Fix off-by-one in testDoesNotSubmitRerouteTaskTooFrequently (#68316)
b4919ee 
We reroute when the elapsed time is >= 60000ms, but the test assumes
that no reroute happens exactly at 60000ms. This commit fixes this
off-by-one-ms error.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 27, 2021
@DaveCTurner
Fix off-by-one in testDoesNotSubmitRerouteTaskTooFrequently
797fef2 
We reroute when the elapsed time is >= 60000ms, but the test assumes
that no reroute happens exactly at 60000ms. This commit fixes this
off-by-one-ms error.

Relates elastic#60869 which introduced this test issue
Relates elastic#68316 which mostly fixed this test issue except this one spot
Closes elastic#71424
@DaveCTurner DaveCTurner mentioned this pull request Apr 27, 2021
Merged
DaveCTurner added a commit that referenced this pull request Apr 27, 2021
@DaveCTurner
Fix off-by-one in testDoesNotSubmitRerouteTaskTooFrequently (#72313)
1d7dfde 
We reroute when the elapsed time is >= 60000ms, but the test assumes
that no reroute happens exactly at 60000ms. This commit fixes this
off-by-one-ms error.

Relates #60869 which introduced this test issue
Relates #68316 which mostly fixed this test issue except this one spot
Closes #71424
DaveCTurner added a commit that referenced this pull request Apr 27, 2021
@DaveCTurner
Fix off-by-one in testDoesNotSubmitRerouteTaskTooFrequently (#72313)
ca7db22 
We reroute when the elapsed time is >= 60000ms, but the test assumes
that no reroute happens exactly at 60000ms. This commit fixes this
off-by-one-ms error.

Relates #60869 which introduced this test issue
Relates #68316 which mostly fixed this test issue except this one spot
Closes #71424
DaveCTurner added a commit that referenced this pull request Apr 27, 2021
@DaveCTurner
Fix off-by-one in testDoesNotSubmitRerouteTaskTooFrequently (#72313)
0e9963d 
We reroute when the elapsed time is >= 60000ms, but the test assumes
that no reroute happens exactly at 60000ms. This commit fixes this
off-by-one-ms error.

Relates #60869 which introduced this test issue
Relates #68316 which mostly fixed this test issue except this one spot
Closes #71424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrx tlrx tlrx approved these changes

@original-brownbear original-brownbear original-brownbear approved these changes

Assignees
No one assigned
Labels
:Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Meta label for distributed team >test Issues or PRs that are addressing/adding tests v7.11.1 v7.12.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DaveCTurner @elasticmachine @tlrx @original-brownbear @jakelandis