[REST Compatible API] Reindex size field #69037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit elastic#43373 has removed outer level size field in version 7. This commit allows for the use of the size field in server ES8 using compatible REST API. relates elastic#51816
pgomulka
commented
Feb 16, 2021
| @@ -158,3 +159,19 @@ if (Os.isFamily(Os.FAMILY_WINDOWS)) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| tasks.named("yamlRestCompatTest").configure { | |||
There was a problem hiding this comment.
a test to validate the change
./gradlew ':modules:reindex:yamlRestCompatTest' --tests "org.elasticsearch.index.reindex.ReindexClientYamlTestSuiteIT.test {yaml=reindex/30_search/Sorting and size combined}" -Dtests.security.manager=true -Dtests.locale=fi -Dtests.timezone=Navajo -Druntime.java=15
jakelandis
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
LGTM, I like the surgical approach.
Suggested commit log:
For re-index requests, the outer most "size" field was deprecated and
renamed to "max_docs" in 7.x. With this commit, the "size" field will
remain available (but still deprecated) through out 8.x when REST API
compatibility is requested.
relates #51816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit #43373 has removed outer level size field in version 7.
This commit allows for the use of the size field in server ES8 using
compatible REST API.
relates #51816
This is a surgical approach with just adding a new field declaration to existing parser. A different - copying - approach is presented here #68355