SQL: Verify binary fields found in non-project to have the doc_values #69128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a verifier rule to check that any fields used in filtering, aggregations or ordering has the doc_values. Otherwise the query will fail in ES with a less obvious reason.
- layout fixes.
|
@elasticmachine update branch |
elasticmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Feb 19, 2021
…elastic#69128) This adds a verifier rule to check that any fields used in filtering, aggregations or ordering has the doc_values. Otherwise the query will either fail in ES with a less obvious and more verbose reason OR plainly give wrong results if filtering with `IS [NOT] NULL`. (cherry picked from commit 1b9ec88)
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Feb 19, 2021
…elastic#69128) This adds a verifier rule to check that any fields used in filtering, aggregations or ordering has the doc_values. Otherwise the query will either fail in ES with a less obvious and more verbose reason OR plainly give wrong results if filtering with `IS [NOT] NULL`. (cherry picked from commit 1b9ec88)
bpintea
added a commit
that referenced
this pull request
Feb 19, 2021
…#69128) (#69257) This adds a verifier rule to check that any fields used in filtering, aggregations or ordering has the doc_values. Otherwise the query will either fail in ES with a less obvious and more verbose reason OR plainly give wrong results if filtering with `IS [NOT] NULL`. (cherry picked from commit 1b9ec88)
bpintea
added a commit
that referenced
this pull request
Feb 19, 2021
…#69128) (#69256) This adds a verifier rule to check that any fields used in filtering, aggregations or ordering has the doc_values. Otherwise the query will either fail in ES with a less obvious and more verbose reason OR plainly give wrong results if filtering with `IS [NOT] NULL`. (cherry picked from commit 1b9ec88)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a verifier rule to check that any fields used in filtering,
aggregations or ordering has the doc_values. Otherwise the query will
either fail in ES with a less obvious and more verbose reason OR plainly
give wrong results if filtering with
IS [NOT] NULL.Closes #68229.