Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Fix manifest version tag in Tableau connector #71524

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

bpintea
Copy link
Contributor

@bpintea bpintea commented Apr 9, 2021

The version needs to be contained in the plugin-version tag, not version one.

The version needs to be contained in the `plugin-version` tag, not
`version` one.
@bpintea bpintea requested a review from astefan April 9, 2021 08:32
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Apr 9, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea bpintea merged commit a674b26 into elastic:master Apr 12, 2021
@bpintea bpintea deleted the fix/tableau_versioning branch April 12, 2021 13:28
bpintea added a commit that referenced this pull request Apr 12, 2021
The version needs to be contained in the `plugin-version` tag, not
`version` one.

(cherry picked from commit a674b26)
bpintea added a commit that referenced this pull request Apr 12, 2021
The version needs to be contained in the `plugin-version` tag, not
`version` one.

(cherry picked from commit a674b26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants