Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fix wrong error upper bound when performing incremental reductions (#43874) #76475

Merged
merged 2 commits into from
Aug 16, 2021

Commits on Aug 12, 2021

  1. Fix wrong error upper bound when performing incremental reductions (e…

    …lastic#43874)
    
    When performing incremental reductions, 0 value of docCountError may mean that
    the error was not previously calculated, or that the error was indeed previously
    calculated and its value was 0. We end up rejecting true values set to 0 this
    way. This may lead to wrong upper bound of error in result. To fix it, this PR
    makes docCountError nullable. null values mean that error was not calculated
    yet.
    
    Fixes elastic#40005
    
    Co-authored-by: Igor Motov <igor@motovs.org>
    Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
    3 people committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    b7cc6eb View commit details
    Browse the repository at this point in the history
  2. Fix docCountError calculation for multiple reduces (elastic#76391)

    Fix docCountError calculation in case of multiple reduces. It fixes 2 mistakes
    in elastic#43874. The first error was introduced in the original PR, where unknown doc
    count errors were initialized equal to 0, the second was introduced during in
    order to fix the first one by ignoring these 0s, which essentially disabled the
    original fix.
    
    Fixes elastic#75667
    imotov committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    5db7196 View commit details
    Browse the repository at this point in the history