[8.0] SQL: Fix qualified attribute resolution with CCS (#81320) #81570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the fields are qualified only by the index name in a cross cluster search query, the field resolution was failing since an attribute's qualification contains the cluster name, while a field's doesn't. This changes the existing `Attribute#qualifiedName()` to return a qualification including the index name only and adds (for completion) a new method, `fullyQualifiedName()`, which will return the 'cluster:index' qualification. This will allow queries like this to work: `SELECT remote_index.field FROM remote_cluster:remote_index` or `SELECT remote_index.field FROM remote_index` when the cluster is provided through the xDBC "cluster" parameter.
bpintea
added
the
auto-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.0: