-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Cluster & XPack clients from HLRC (#83423) #83593
Remove Cluster & XPack clients from HLRC (#83423) #83593
Conversation
Hi @gmarouli, I've created a changelog YAML for you. |
@elasticmachine run elasticsearch-ci/part-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming CI is happy, thanks Mary!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Mary!
Oh hah, I liked this PR so much I reviewed it twice, whoops! |
I share the excitement, I got to see a bit more of the clients and the tests, it was a good opportunity! Also, cleaning code like this is sooooo awesome! It might be counter intuitive for the people that see developers as code producing machines but it makes total sense in reality ;). I am working on tests, 2 failures were my fault. I think I fixed it but let's see. |
No description provided.