Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax data path deprecations from critical to warn #85952

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Relax data path deprecations from critical to warn #85952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71354f8
Relax data path deprecations from critical to warn
rjernst Apr 18, 2022
7a5dcd5
Update docs/changelog/85952.yaml
rjernst Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/85952.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 85952
summary: Relax data path deprecations from critical to warn
area: Infra/Core
type: bug
issues: []
2 changes: 1 addition & 1 deletion ...deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ static DeprecationIssue checkIndexDataPath(IndexMetadata indexMetadata) {
final String url = "https://www.elastic.co/guide/en/elasticsearch/reference/7.13/"
+ "breaking-changes-7.13.html#deprecate-shared-data-path-setting";
final String details = "Found index data path configured. Discontinue use of this setting.";
return new DeprecationIssue(DeprecationIssue.Level.CRITICAL, message, url, details, false, null);
return new DeprecationIssue(DeprecationIssue.Level.WARNING, message, url, details, false, null);
}
return null;
}
Expand Down
2 changes: 1 addition & 1 deletion .../deprecation/src/main/java/org/elasticsearch/xpack/deprecation/NodeDeprecationChecks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ static DeprecationIssue checkSharedDataPathSetting(
final String url = "https://www.elastic.co/guide/en/elasticsearch/reference/7.13/"
+ "breaking-changes-7.13.html#deprecate-shared-data-path-setting";
final String details = "Found shared data path configured. Discontinue use of this setting.";
return new DeprecationIssue(DeprecationIssue.Level.CRITICAL, message, url, details, false, null);
return new DeprecationIssue(DeprecationIssue.Level.WARNING, message, url, details, false, null);
}
return null;
}
Expand Down
2 changes: 1 addition & 1 deletion ...cation/src/test/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecksTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public void testIndexDataPathSetting() {
issues,
contains(
new DeprecationIssue(
DeprecationIssue.Level.CRITICAL,
DeprecationIssue.Level.WARNING,
"setting [index.data_path] is deprecated and will be removed in a future version",
expectedUrl,
"Found index data path configured. Discontinue use of this setting.",
Expand Down
2 changes: 1 addition & 1 deletion ...ecation/src/test/java/org/elasticsearch/xpack/deprecation/NodeDeprecationChecksTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void testSharedDataPathSetting() {
issues,
contains(
new DeprecationIssue(
DeprecationIssue.Level.CRITICAL,
DeprecationIssue.Level.WARNING,
"setting [path.shared_data] is deprecated and will be removed in a future version",
expectedUrl,
"Found shared data path configured. Discontinue use of this setting.",
Expand Down