Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move kNN search and dense vectors to core #87815

Merged
merged 5 commits into from
Jun 23, 2022
Merged

Move kNN search and dense vectors to core #87815

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d957cf
Move kNN search to core
jtibshirani Jun 16, 2022
0de231b
Remove unnecessary method MappingLookup#getKnnVectorsFormatForField
jtibshirani Jun 21, 2022
93031ed
Tweak module order in module-info
jtibshirani Jun 21, 2022
010ffb8
Rename DenseVectorFunctionTests to VectorScoreScriptUtilsTests
jtibshirani Jun 21, 2022
48f4d9d
Correct custom codec definition
jtibshirani Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Correct custom codec definition
  • Loading branch information
@jtibshirani
jtibshirani committed Jun 22, 2022
commit 48f4d9db2c6d8647256ad775754e904ff4ce0fba
8 changes: 5 additions & 3 deletions server/src/main/java/org/elasticsearch/index/codec/PerFieldMapperCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,12 @@ public PostingsFormat getPostingsFormatForField(String field) {
public KnnVectorsFormat getKnnVectorsFormatForField(String field) {
Mapper mapper = mapperService.mappingLookup().getMapper(field);
if (mapper instanceof DenseVectorFieldMapper vectorMapper) {
return vectorMapper.getKnnVectorsFormatForField();
} else {
return super.getKnnVectorsFormatForField(field);
KnnVectorsFormat format = vectorMapper.getKnnVectorsFormatForField();
if (format != null) {
return format;
}
}
return super.getKnnVectorsFormatForField(field);
}

@Override
Expand Down