Upgrade to new Lucene snapshot #87932
Conversation
| @@ -2408,6 +2408,8 @@ private IndexWriterConfig getIndexWriterConfig() { | |||
| mergePolicy = new ShuffleForcedMergePolicy(mergePolicy); | |||
| } | |||
| iwc.setMergePolicy(mergePolicy); | |||
| // TODO: Introduce an index setting for setMaxFullFlushMergeWaitMillis | |||
| iwc.setMaxFullFlushMergeWaitMillis(-1); | |||
There was a problem hiding this comment.
We disable merges on refresh here.
dnhatn
added
the
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
@ywelsch brought up the point that merge-on-refresh might also interfere in undesirable ways with internal refreshes. Let's disable merge-on-refresh always for now, and discuss how to enable it (including a setting if necessary) in a separate PR? |
Yes, it's already disabled in this PR. |
|
Thanks Adrien. |
This PR uses Lucene-9.3 snapshot in Elasticsearch 8.4. Noticeable changes in this Lucene snapshot:
I have to disable merges on refresh in this upgrade because some tests rely on the stable storage after refresh/flush. Should we introduce an index setting for merges-on-fresh so users can disable or adjust the wait-for-merges on refresh/flush interval? Other option is to add a test-only setting so we can disable or use random value in tests. @jpountz WDYT?