Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to kNN search guide in dense_vector docs #91372

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

jtibshirani
Copy link
Contributor

Before these docs linked to script_score and approximate kNN separately, but
now we can link to a single page that describes both approaches. This change
also removes a link to the deprecated _knn_search API.

Before it linked to script_score and approximate kNN separately, but now we have
a single page that describes both approaches. This change also removes a link to
the deprecated _knn_search API.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Search Meta label for search team labels Nov 8, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtibshirani jtibshirani merged commit 3948d4b into elastic:main Nov 8, 2022
@jtibshirani jtibshirani deleted the dense-vector-docs branch November 8, 2022 15:46
jtibshirani added a commit that referenced this pull request Nov 8, 2022
Before it linked to script_score and approximate kNN separately, but now we have
a single page that describes both approaches. This change also removes a link to
the deprecated _knn_search API.
jtibshirani added a commit that referenced this pull request Nov 8, 2022
Before it linked to script_score and approximate kNN separately, but now we have
a single page that describes both approaches. This change also removes a link to
the deprecated _knn_search API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Relevance/Vectors Vector search Team:Docs Meta label for docs team Team:Search Meta label for search team v8.4.4 v8.5.1 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants