Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] More robust order of assertions #99461

Merged
merged 2 commits into from
Sep 12, 2023
Merged

[Test] More robust order of assertions #99461

merged 2 commits into from
Sep 12, 2023

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Sep 12, 2023

This PR adjusts the order of assertions to ensure we are done with the atomic reference variable in the previous assertions before changing it to null.

Resolves: #99406

@ywangd
[Test] More robust order of assertions
9d16cd1 
This PR adjusts the order of assertions to ensure we are done with the
atomic reference variable in the previous assertions before changing it
to null.

Resolves: elastic#99406
@ywangd ywangd added >test Issues or PRs that are addressing/adding tests :Distributed/Network Http and internode communication implementations v8.11.0 labels Sep 12, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label Sep 12, 2023
@ywangd ywangd added the v8.10.0 label Sep 12, 2023
albertzaharovits
albertzaharovits approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd ywangd added auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Sep 12, 2023
@elasticsearchmachine elasticsearchmachine merged commit 16a4e54 into elastic:main Sep 12, 2023
11 checks passed
@ywangd ywangd deleted the es-99406 branch September 12, 2023 09:25
@ywangd ywangd mentioned this pull request Sep 12, 2023
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.10

ywangd added a commit to ywangd/elasticsearch that referenced this pull request Sep 12, 2023
@ywangd
[Test] More robust order of assertions (elastic#99461)
ae859f8 
This PR adjusts the order of assertions to ensure we are done with the
atomic reference variable in the previous assertions before changing it
to null.

Resolves: elastic#99406
elasticsearchmachine pushed a commit that referenced this pull request Sep 12, 2023
@ywangd
[Test] More robust order of assertions (#99461) (#99468)
9d8b957 
This PR adjusts the order of assertions to ensure we are done with the
atomic reference variable in the previous assertions before changing it
to null.

Resolves: #99406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertzaharovits albertzaharovits albertzaharovits approved these changes

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Network Http and internode communication implementations Team:Distributed Meta label for distributed team >test Issues or PRs that are addressing/adding tests v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
3 participants
@ywangd @elasticsearchmachine @albertzaharovits