Skip to content

Commit

Permalink
Remove EuiDescritpionList IE comments
Browse files Browse the repository at this point in the history
- Many consumers are overriding `width` instead of `flex-basis` at this point for the component, so changing it to flex-basis would cause unnecessary churn
- `width` is also still valid and intuitive to use instead over flex-basis
  • Loading branch information
cee-chen committed Aug 22, 2022
1 parent c3fe3bc commit 06ef338
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const euiDescriptionListDescriptionStyles = (
const { euiTheme } = euiThemeContext;

const columnDisplay = `
${logicalCSS('width', '50%')} // Flex-basis doesn't work in IE with padding
${logicalCSS('width', '50%')}
${logicalCSS('padding-left', euiTheme.size.s)}
&:not(:first-of-type) {
${logicalCSS('margin-top', euiTheme.size.base)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const euiDescriptionListTitleStyles = (euiThemeContext: UseEuiTheme) => {
const { euiTheme, colorMode } = euiThemeContext;

const columnDisplay = `
${logicalCSS('width', '50%')} // Flex-basis doesn't work in IE with padding
${logicalCSS('width', '50%')}
${logicalCSS('padding-right', euiTheme.size.s)}
`;
return {
Expand Down

0 comments on commit 06ef338

Please sign in to comment.