Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Broken keyboard interaction in x clear button #7289

Open
Tracked by #182611
nickofthyme opened this issue Oct 17, 2023 · 4 comments
Open
Tracked by #182611

[EuiComboBox] Broken keyboard interaction in x clear button #7289

nickofthyme opened this issue Oct 17, 2023 · 4 comments

Comments

@nickofthyme
Copy link
Contributor

Describe the bug

Unable to access clear button on EuiComboBox from keyboard navigation.

Screen Recording 2023-10-16 at 07 14 26 PM

  1. Go to https://eui.elastic.co/#/forms/combo-box
  2. Click to focus and open any clearable comboBox
  3. Make a selection so the input is filled
  4. Press esc to close list and tab to the x clear button
  5. Press enter to clear the selection
  6. Notice nothing happens

Clicking the x has the intended affect just not via keyboard interaction.

@nickofthyme nickofthyme added bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible accessibility - keyboard labels Oct 17, 2023
@nickofthyme
Copy link
Contributor Author

nickofthyme commented Oct 17, 2023

Just to add context -- using the space does work to trigger the x button as expected. Maybe that's the intended use. I'm not sure when or where space vs enter should be used but from this link it seems it would be better if both space & enter triggered the button.

image

@cee-chen
Copy link
Member

+1, can confirm/repro the problem. FWIW, we've solved this problem in EuiSelectable (#6631), so this bug will go away for free once we update EuiComboBox to dogfood EuiSelectable (#2841).

The latter is on my list for the next month or so, so I'm tempted to wait until then to try and fix this issue.

@cee-chen cee-chen removed the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Oct 26, 2023
@hrmtn
Copy link

hrmtn commented Dec 28, 2023

In the showcase https://eui.elastic.co/#/forms/combo-box, space triggers the clear and not enter.

@nickofthyme
Copy link
Contributor Author

@hrmtn correct that's what I stated in #7289 (comment), the question is whether it should trigger using either space or enter not only space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants