Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended EuiFieldText in EuiSuggestInput #4452

Merged
merged 13 commits into from
Jan 28, 2021

Conversation

K-Kumar-01
Copy link
Contributor

@K-Kumar-01 K-Kumar-01 commented Jan 27, 2021

Summary

Closes #4330
Added the code to expose the EuiFieldTextProps

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

K-Kumar-01 and others added 11 commits December 15, 2020 16:01
Issue number 4239
Ability to unregister the tooltip plugin added
Updated the editor example doc to show how to use it
Added the ability to unregsiter inbuilt UI plugins
Addresses issue 4239

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
Default UI Plugins initialized
Warning added on injecting tooltip plugin

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
Issue Number - 4330

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cchaos
Copy link
Contributor

cchaos commented Jan 27, 2021

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4452/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @K-Kumar-01 ! LGTM, can you just add a changelog entry as well?

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@K-Kumar-01
Copy link
Contributor Author

Thanks @K-Kumar-01 ! LGTM, can you just add a changelog entry as well?

@cchaos
I have added the chabgelog entry. Let me know if there are any changes required :)

@cchaos cchaos changed the title Eui suggest 4330 Extended EuiFieldText in EuiSuggestInput Jan 28, 2021
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@cchaos
Copy link
Contributor

cchaos commented Jan 28, 2021

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4452/

@cchaos cchaos merged commit 523a117 into elastic:master Jan 28, 2021
@K-Kumar-01 K-Kumar-01 deleted the EuiSuggest-4330 branch January 31, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiSuggest] No EuiFieldText properties exposed in type definitions
4 participants