[Chore] : Migrated axe-puppeteer to @axe-core/puppeteer

[akashgp09]

Summary

This PR Fixes: #4436
Migrated deprecated dependency axe-puppeteer v1.1.1 to @axe-core/puppeteer v4.1.1

Note:

Fixed one accessibility error that occured after migrating to @axe-core/puppeteer v4.1.1
Now all a11y tests are passing :

Checklist

• Check against all themes for compatibility in both light and dark modes
• Checked in mobile
• Checked in Chrome, Safari, Edge, and Firefox
• Props have proper autodocs and playground toggles
• Added documentation
  -[ ] Checked Code Sandbox works for the any docs examples
• Added or updated jest tests
• Checked for breaking changes and labeled appropriately
• Checked for accessibility including keyboard-only and screenreader modes
• A changelog entry exists and is marked appropriately

[kibanamachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[myasonik]

Nice! Your fix in tour_step.tsx was really good! I thought we were going to have to do a bunch of work on the consuming side but your fix is better.

I left a few suggestions for how to improve popover.tsx for other consumers but that should be it, I think!

[akashgp09]

@myasonik thank you for the review :)
Will make the required changes soon.

[myasonik]

jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_4482/

[myasonik]

jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_4482/

[myasonik]

@akashgp09 Looks like a snapshot test failed.

If you run yarn test-unit you should be able to see the output locally and, if everything looks correct, yarn test-unit -u should update the snapshots.

[myasonik]

Jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_4482/

[myasonik]

Jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_4482/

[myasonik]

@akashgp09 looks like there's another a11y failure that you weren't getting locally. I'll take a look and see if I can reproduce it.

[akashgp09]

Okay, thank you @myasonik.

[myasonik]

I wasn't able to reproduce the issue locally when running the test suite but it does show up when running the axe addon in browser.

It's inside the Youtube iframe so that's far beyond our control. I tried ignoring any iframe contents so we'll see if that works in CI.

Github actions seem to be having a bad day so we'll have to wait until we can run it to verify.

[myasonik]

jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_4482/

[thompsongl]

jenkins test this

Error: Timed out waiting for: http-get://localhost:9999

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_4482/

[myasonik]

This failed on the iframe issue again so I guess my fix didn't work... Will try again.

Huh - seems to be an issue in axe: dequelabs/axe-core#2690

I wonder why it's not happening locally and why the exclusion didn't work...

[thompsongl]

jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_4482/

[myasonik]

jenkins test this

Confirming everything works by trying for two green builds in a row

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_4482/

[thompsongl]

LGTM!

[myasonik]

Thanks for your work on this @akashgp09! Really appreciated and apologies for our CI flakiness on this one!

[akashgp09]

@myasonik thank you for you continuous feedbacks and guidance on this one. Finally it's done🥳