Fix datagrid freezing on open flyout #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4813/ |
snide
reviewed
May 20, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4813/ |
thompsongl
approved these changes
May 24, 2021
There was a problem hiding this comment.
LGTM; thanks @flash1293
Ran locally using a recreation of the codesandbox repro
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4799
As described in the issue, this applies a quick fix to prevent the browser from freezing when using flyout together with datagrid.
I had to clean up some potential dangling timeouts in popover because they were failing the tests (as I'm waiting for the next tick in the data grid cell unit test, some leftover timeouts from other tests got triggered)