-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Give rows actual positions/dimensions #5555
Commits on Feb 7, 2022
-
Pass positioning and height/width to portalled rows
+ adjust scrolling workaround to obtain offsetTop from row parent instead of cell, now that individual cells have a top: 0
Configuration menu - View commit details
-
Copy full SHA for 204573b - Browse repository at this point
Copy the full SHA 204573bView commit details -
Configuration menu - View commit details
-
Copy full SHA for be4c751 - Browse repository at this point
Copy the full SHA be4c751View commit details -
Fix scrolling workaround to use row offsetTop
- now that cells are relative to the row parent, their offsetTop is 0
Configuration menu - View commit details
-
Copy full SHA for 2fae704 - Browse repository at this point
Copy the full SHA 2fae704View commit details -
- Remove `@include euiDataGridRowCell` mixin and target the row directly - Remove isStripableRow cell logic and instead use CSS nth-child for alternating stripes - Swap stripes and highlight CSS so that highlight takes precendence over stripes without an !important - Remove background color on individual cells to allow row colors to show through (NB: grid body is already set to the correct background color as well)
Configuration menu - View commit details
-
Copy full SHA for 283e40b - Browse repository at this point
Copy the full SHA 283e40bView commit details -
Add unit tests for row manager
- skipping the mutation observer for now
Configuration menu - View commit details
-
Copy full SHA for 0576101 - Browse repository at this point
Copy the full SHA 0576101View commit details -
- cells no longer have a set background color (to allow row color to bleed through), and we were previously relying on the grid body's bg color to be white
Configuration menu - View commit details
-
Copy full SHA for ec39fe8 - Browse repository at this point
Copy the full SHA ec39fe8View commit details
Commits on Feb 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b6b107a - Browse repository at this point
Copy the full SHA b6b107aView commit details -
Fix row widths bugging out due to stale containerRef reference
- using CSS `left`/`right` and `relative` on the inner grid parent solves the issue instead, as the row is now always correct width
Configuration menu - View commit details
-
Copy full SHA for 006df04 - Browse repository at this point
Copy the full SHA 006df04View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2397ee - Browse repository at this point
Copy the full SHA a2397eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for aef8c64 - Browse repository at this point
Copy the full SHA aef8c64View commit details -
Fix rows to add
--striped
class instead of CSS :nth-child- which does not work well due to children changing on virtualization + set additional visible row index data attribute for extra detail + use dataset
Configuration menu - View commit details
-
Copy full SHA for a71c314 - Browse repository at this point
Copy the full SHA a71c314View commit details -
- was previously not working on prod, and now it does
Configuration menu - View commit details
-
Copy full SHA for ddef677 - Browse repository at this point
Copy the full SHA ddef677View commit details
Commits on Feb 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6f63371 - Browse repository at this point
Copy the full SHA 6f63371View commit details -
Revert "[REVERT ME] Test striped rows on virtualized grids"
This reverts commit aef8c64.
Configuration menu - View commit details
-
Copy full SHA for f4702f7 - Browse repository at this point
Copy the full SHA f4702f7View commit details