Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Give rows actual positions/dimensions #5555

Merged
merged 14 commits into from
Feb 10, 2022

Commits on Feb 7, 2022

  1. Pass positioning and height/width to portalled rows

    + adjust scrolling workaround to obtain offsetTop from row parent instead of cell, now that individual cells have a top: 0
    cee-chen committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    204573b View commit details
    Browse the repository at this point in the history
  2. Update snapshots

    cee-chen committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    be4c751 View commit details
    Browse the repository at this point in the history
  3. Fix scrolling workaround to use row offsetTop

    - now that cells are relative to the row parent, their offsetTop is 0
    cee-chen committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    2fae704 View commit details
    Browse the repository at this point in the history
  4. Simplify row CSS

    - Remove `@include euiDataGridRowCell` mixin and target the row directly
    
    - Remove isStripableRow cell logic and instead use CSS nth-child for alternating stripes
    
    - Swap stripes and highlight CSS so that highlight takes precendence over stripes without an !important
    
    - Remove background color on individual cells to allow row colors to show through (NB: grid body is already set to the correct background color as well)
    cee-chen committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    283e40b View commit details
    Browse the repository at this point in the history
  5. Add unit tests for row manager

    - skipping the mutation observer for now
    cee-chen committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    0576101 View commit details
    Browse the repository at this point in the history
  6. Account for elastic#5562

    - cells no longer have a set background color (to allow row color to bleed through), and we were previously relying on the grid body's bg color to be white
    cee-chen committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    ec39fe8 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Configuration menu
    Copy the full SHA
    b6b107a View commit details
    Browse the repository at this point in the history
  2. Fix row widths bugging out due to stale containerRef reference

    - using CSS `left`/`right` and `relative` on the inner grid parent solves the issue instead, as the row is now always correct width
    cee-chen committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    006df04 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a2397ee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aef8c64 View commit details
    Browse the repository at this point in the history
  5. Fix rows to add --striped class instead of CSS :nth-child

    - which does not work well due to children changing on virtualization
    
    + set additional visible row index data attribute for extra detail
    
    + use dataset
    cee-chen committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    a71c314 View commit details
    Browse the repository at this point in the history
  6. Fix striped footer rows

    - was previously not working on prod, and now it does
    cee-chen committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    ddef677 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Configuration menu
    Copy the full SHA
    6f63371 View commit details
    Browse the repository at this point in the history
  2. Revert "[REVERT ME] Test striped rows on virtualized grids"

    This reverts commit aef8c64.
    cee-chen committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    f4702f7 View commit details
    Browse the repository at this point in the history