-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Fix inconsistent cell header focus when clicking another cell header when a cell header popover is already open #5556
Conversation
- when clicking to another header cell when a cell header popover is already open
f116852
to
2c37ee4
Compare
@breehall Was hoping you had some time this week to review this small datagrid bug - let me know if not! |
2c37ee4
to
5f7a109
Compare
Preview documentation changes for this PR: https://eui.elastic.co/pr_5556/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5556/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and it's awesome that the solution was a quick fix. I checked this in the PR preview with mouse and keyboard navigation. Thanks Constance!
Preview documentation changes for this PR: https://eui.elastic.co/pr_5556/ |
…r cell header when a cell header popover is already open (elastic#5556) * Fix cell header focus not correctly updating - when clicking to another header cell when a cell header popover is already open * Add changelog entry * Changelog
Summary
closes #5352
When a cell header's actions popover is already open, clicking another header cell does not correctly update focus. Note that this bug seems to only occur on webkit browsers (Chrome/Edge/Safari), and does not occur on production on Firefox.
Before
Note how the blue focus ring keeps jumping back to the first cell header.
After
Note how the blue focus ring now correctly jumps to the most recently clicked cell header.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Checked for breaking changes and labeled appropriately