Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] Change data grid body background to light gray #5562

Merged
merged 5 commits into from
Jan 31, 2022
Merged

[EuiDataGrid] Change data grid body background to light gray #5562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c05df68
Show unrendered cells as gray when scrolling/not yet virtualized
cee-chen Jan 25, 2022
cc34065
Misc cleanup - move toolbar related css to toolbar scss file
cee-chen Jan 25, 2022
01256b2
Add changelog entry
cee-chen Jan 25, 2022
6d2faae
Merge branch 'main' into datagrid/4458/background-color
constancecchen Jan 25, 2022
0b10572
Merge branch 'main' into datagrid/4458/background-color
constancecchen Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## [`main`](https://github.com/elastic/eui/tree/main)

- Updated `EuiDataGrid`s with scrolling content to always have a border around the grid body and any scrollbars ([#5563](https://github.com/elastic/eui/pull/5563))
- Updated `EuiDataGrid`'s body to a light gray background, which primarily shows when scrolling through virtualized content ([#5562](https://github.com/elastic/eui/pull/5562))
- Added referenceable `id` for the generated label in `EuiFormRow` ([#5574](https://github.com/elastic/eui/pull/5574))
- Addeed optional attribute configurations in `EuiPopover` to aid screen reader announcements ([#5574](https://github.com/elastic/eui/pull/5574))
- Added `ref` passthroughs to `EuiIputPopover` subcomponents ([#5574](https://github.com/elastic/eui/pull/5574))
Expand Down
10 changes: 1 addition & 9 deletions src/components/datagrid/_data_grid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
overflow: hidden;
z-index: 1; // Sits below the controls above it and pagination below it
position: relative;
background: $euiColorEmptyShade;
background: $euiPageBackgroundColor;
Copy link
Member Author

@cee-chen cee-chen Jan 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miukimiu I'm not totally sure if we still even want this change or feedback item per #4458 and would appreciate your awesome designer eyes here! https://eui.elastic.co/pr_5562/#/tabular-content/data-grid-virtualization to test the change

font-feature-settings: 'tnum' 1; // Tabular numbers
}

Expand All @@ -51,14 +51,6 @@
}
}


.euiDataGrid__controlScroll {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a misc extra cleanup, I noticed that this belonged better in the toolbar CSS and not the overall datagrid and decided to move it.

@include euiYScrollWithShadows;
max-height: $euiDataGridPopoverMaxHeight;
padding: $euiSizeS;
margin: -$euiSizeS; // Offset against the panel to make the scrollbar flush scrollbars
}

.euiDataGrid__focusWrap {
height: 100%;
}
Expand Down
7 changes: 7 additions & 0 deletions src/components/datagrid/controls/_data_grid_toolbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,10 @@
transition: none !important;
margin-top: -$euiSizeS;
}

.euiDataGrid__controlScroll {
@include euiYScrollWithShadows;
max-height: $euiDataGridPopoverMaxHeight;
padding: $euiSizeS;
margin: -$euiSizeS; // Offset against the panel to make the scrollbar flush scrollbars
}